Link to streamlog instead of Marlin_LIBRARIES #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
marlin-libraries
branch
from
f0751ec to
3010b8f
Compare
tmadlener
reviewed
Aug 22, 2024
Comment on lines
26
to
27
| FIND_PACKAGE( Marlin 1.0 REQUIRED ) # minimum required Marlin version | ||
| INCLUDE_DIRECTORIES( ${Marlin_INCLUDE_DIRS} ) |
There was a problem hiding this comment.
Do we need to find Marlin if we only want streamlog?
There was a problem hiding this comment.
There are some includes that need Marlin:
https://github.com/iLCSoft/KiTrack/blob/master/include/KiTrack/SubsetSimple.h#L6 so it should be needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
streamloginstead ofMarlin_LIBRARIES.ENDRELEASENOTES
Uncovered by iLCSoft/Marlin#56, only
streamlogis needed byKiTrack.